Skip to content

Conversation

@bjee19
Copy link
Contributor

@bjee19 bjee19 commented Oct 20, 2025

Cherry-pick #4104. Add a conditional to inference pool status, so we make a k8sclient call on the InferencePool object only if inference extension is enabled.

Add a conditional to inference pool status, so we make a k8sclient call on the InferencePool object only if inference extension is enabled.
@bjee19 bjee19 requested a review from a team as a code owner October 20, 2025 16:16
@github-actions github-actions bot added the bug Something isn't working label Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.49%. Comparing base (e4eed2d) to head (a30410c).
⚠️ Report is 1 commits behind head on release-2.2.

Files with missing lines Patch % Lines
internal/controller/handler.go 0.00% 13 Missing and 1 partial ⚠️
internal/controller/manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.2    #4115      +/-   ##
===============================================
- Coverage        86.62%   86.49%   -0.13%     
===============================================
  Files              131      131              
  Lines            17794    17796       +2     
  Branches            74       74              
===============================================
- Hits             15414    15393      -21     
- Misses            2182     2202      +20     
- Partials           198      201       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjee19 bjee19 merged commit 1f4392a into release-2.2 Oct 20, 2025
60 of 61 checks passed
@bjee19 bjee19 deleted the bug/inference-pool-status-error branch October 20, 2025 18:29
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants